Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: fixes for options with numeric values and toggleable Select #583

Merged
merged 6 commits into from
Jan 31, 2020
Merged

fix: fixes for options with numeric values and toggleable Select #583

merged 6 commits into from
Jan 31, 2020

Commits on Jan 30, 2020

  1. fix: avoid mapping options for using in ui-core Select

    @edoardo
    edoardo committed Jan 30, 2020
    Configuration menu
    Copy the full SHA
    aec4ebb View commit details
    Browse the repository at this point in the history

  2. fix: fix behaviour of legendSet option to silence warnings

    @edoardo
    edoardo committed Jan 30, 2020
    Configuration menu
    Copy the full SHA
    b2965f8 View commit details
    Browse the repository at this point in the history

  3. fix: use strings for Select options 

    ui-core does not accept numeric values for the Select options.
    @edoardo
    edoardo committed Jan 30, 2020
    Configuration menu
    Copy the full SHA
    8d19cba View commit details
    Browse the repository at this point in the history

  4. refactor: change behaviour of toggable Select 

    If it's toggleable it means that the checkbox acts as a switch between
the default value for the option (aka disabled option) and the other
possible values listed in the Select.

The returned value used when saving the AO must then be set based on
both the Checkbox and the Select.
    @edoardo
    edoardo committed Jan 30, 2020
    Configuration menu
    Copy the full SHA
    98b1062 View commit details
    Browse the repository at this point in the history

  5. fix: don't use numeric values for options 

    This requires a conversion for some options, where the value coming from
the api is numeric, but the UI won't work correctly if it's not first
converted into string.
The value must also be converted back to numeric from the UI when saving the AO.
    @edoardo
    edoardo committed Jan 30, 2020
    Configuration menu
    Copy the full SHA
    cb46906 View commit details
    Browse the repository at this point in the history

  6. fix: fix tests for SelectBaseOption component

    @edoardo
    edoardo committed Jan 30, 2020
    Configuration menu
    Copy the full SHA
    aaf47ce View commit details
    Browse the repository at this point in the history