feat: option for data approval level #657
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
In order to test the feature, a analytic system setting must be changed: With that, and if the user has the |
"Learn more" is not clickable.
The authorities values are store within the user object in the store
This is a special type of option, as it's not always available in the UI and it should not be saved in the AO. It should be passed to the analytics api also when downloading the data.
The const is defined in the ApprovalLevel option component and imported in App.js.
edoardo
force-pushed
the
feat/data-approval-level-option
branch
from
1671209
to
26b5a31
Compare
martinkrulltott
approved these changes
Feb 14, 2020
packages/app/src/components/VisualizationOptions/Options/ApprovalLevel.js
Outdated
Show resolved
Hide resolved
packages/app/src/components/VisualizationOptions/Options/ApprovalLevel.js
Show resolved
Hide resolved
Bug came up after adding ApprovalLevel option after CompletedOnly.
dhis2-bot
added a commit
that referenced
this pull request
Feb 17, 2020
# [34.2.0](v34.1.0...v34.2.0) (2020-02-17) ### Features * option for data approval level ([#657](#657)) ([3b7d274](3b7d274))
|
🎉 This PR is included in version 34.2.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a special option, only shown if the user has authority to see unapproved data and the analytics system setting "Max number of years to hide unapproved data in analytics" is set.
In that case the
approvalLevelwith the value set via the UI should be sent as query parameter in the analytics request.