fix: translations need to be determined at render time [v33] [DHIS2-8638] #967
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…-visualizer-app into chore/translations-v33-latest
yarn.lock
Outdated
| @@ -1236,7 +1158,7 @@ | |||
| npmlog "^4.1.2" | |||
| write-file-atomic "^2.3.0" | |||
|
|
|||
| "@material-ui/core@^3.1.2", "@material-ui/core@^3.3.1", "@material-ui/core@^3.9.3": | |||
| "@material-ui/core@^3.1.2": | |||
There was a problem hiding this comment.
Shouldn't this resolve to version "3.9.4" as the others below?
|
I tested this locally, here are my findings. Please note that I haven't verified if there actually are translations available for all of these parts, maybe that should be a first step in the investigation.
Download menu
Dimension context menus. Note: the context menu for unselected dimensions seems translated and fine, only selected dimensions have this issue.
|
…is2/data-visualizer-app into chore/translations-v33-latest
This reverts commit e5c4df4.
martinkrulltott
approved these changes
May 13, 2020
This was referenced Jun 8, 2020
This was referenced Jun 17, 2020
|
🎉 This PR is included in version 33.1.13 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: https://jira.dhis2.org/browse/DHIS2-8638
Translations need to be figured at render-time, rather than just being consts outside of functions. 3rd party libs (analytics, d2-ui components) also updated with the same type of changes.
Also, datasets.js and datatypes.js were removed as they had previously been migrated to the analytics library (but forgotten to delete here). This resulted in removal of some translations from en.pot (not sure if this means some languages will lose their translations?)