-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: latest analytics library for period selector translations (v33) #982
fix: latest analytics library for period selector translations (v33) #982
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code LGTM. Going to test this locally now
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested locally, looks good. Bumped d2-ui to fix the 1-10 of 148
part and we're now waiting for the latest Analytics to fix the No data
part.
🎉 This PR is included in version 33.1.13 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Part of fix for: https://jira.dhis2.org/browse/DHIS2-8638
Note: I already published data-visualizer-plugin v33.1.12 so dashboards could get it.
Finally, fully translated: