Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: use shared dashboard plugin wrapper #3232

Draft
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

edoardo
Copy link
Member

@edoardo edoardo commented Jun 4, 2024

Part of the fix for: DHIS2-17268

Requires dhis2/analytics#1672


Key features

  1. use shared dashboard plugin wrapper

Description

Generic components for plugins are available in app-platform and app-runtime.
Analytics apps are currently having the same components replicated in each repo, a shared dashboard plugin wrapper has been added in analytics.


Known issues

  • an infinite loop happened and this seems to solve it, I'm not sure why and if this is a proper solution.

Screenshots

@dhis2-bot
Copy link
Contributor

dhis2-bot commented Jun 4, 2024

🚀 Deployed on https://pr-3232--dhis2-maps.netlify.app

@dhis2-bot dhis2-bot temporarily deployed to netlify June 4, 2024 14:12 Inactive
@edoardo edoardo force-pushed the refactor/use-platform-plugin-components branch from 56b135d to 04d645c Compare July 3, 2024 10:10
@dhis2-bot dhis2-bot temporarily deployed to netlify July 3, 2024 10:31 Inactive
@edoardo edoardo changed the base branch from dev to master July 3, 2024 11:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants