Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BEBB import #943

Merged
merged 8 commits into from
Aug 13, 2018
Merged

BEBB import #943

merged 8 commits into from
Aug 13, 2018

Conversation

tobiasschweizer
Copy link
Contributor

@tobiasschweizer tobiasschweizer commented Jul 17, 2018

  • import more metadata fields from the library's metadata catalogue (Marc21) for BEBB letters
  • fix some issues for the TEI/XML conversion (use <ref> for links in TEI/XML instead of the empty element <ptr>, support tables)
  • get rid of obsolete beol standoff tags: nowiki and nbsp: nowiki is removed during preprocessing of the XML and nsbp is represented by a character (&#160;)

@codecov
Copy link

codecov bot commented Jul 17, 2018

Codecov Report

Merging #943 into develop will decrease coverage by <.01%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop     #943      +/-   ##
===========================================
- Coverage     82.7%   82.69%   -0.01%     
===========================================
  Files          150      150              
  Lines        16994    16992       -2     
  Branches      1590     1609      +19     
===========================================
- Hits         14055    14052       -3     
- Misses        2939     2940       +1
Flag Coverage Δ
#integration 46.58% <ø> (-0.01%) ⬇️
#unit_e2e 81.57% <ø> (-0.01%) ⬇️
Impacted Files Coverage Δ
...i/src/main/scala/org/knora/webapi/Exceptions.scala 34.78% <0%> (-4.35%) ⬇️
...re/triplestore/http/HttpTriplestoreConnector.scala 83.73% <0%> (-0.48%) ⬇️
...scala/org/knora/webapi/routing/Authenticator.scala 87.2% <0%> (ø) ⬆️
...api/src/main/scala/org/knora/webapi/Settings.scala 98.83% <0%> (+1.1%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a26f216...ef3c83c. Read the comment docs.

Copy link
Contributor

@SepidehAlassi SepidehAlassi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

changes looks good!

Copy link
Contributor

@SepidehAlassi SepidehAlassi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you please check why tests fail?

@tobiasschweizer
Copy link
Contributor Author

It is the code coverage test.

==> Searching for coverage reports in:
/home/travis/build/dhlab-basel/Knora
--> No coverage report found.

@subotic Could you give me a hand here?

@tobiasschweizer
Copy link
Contributor Author

@SepidehAlassi I reran them and now they pass :-)

@tobiasschweizer tobiasschweizer merged commit 414dd77 into develop Aug 13, 2018
@tobiasschweizer tobiasschweizer deleted the wip/beol_bebb_import branch August 15, 2018 08:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants