Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use team colors in charts instead of always "Blue" and "Orange" #32

Closed
erevrav opened this issue Dec 21, 2022 · 2 comments
Closed

use team colors in charts instead of always "Blue" and "Orange" #32

erevrav opened this issue Dec 21, 2022 · 2 comments
Labels
enhancement New feature or request fixed Fix has been confirmed (usually by issue opener)

Comments

@erevrav
Copy link
Collaborator

erevrav commented Dec 21, 2022

What version of the tools are you running, and how?
direct dump from dhmay via pdf

Is your feature request related to a problem? Please describe.
it's hard to tell which team data in an unexpected color goes with. Seeing a team I always associate with green displayed in orange bends my brain.

Describe the solution you'd like
for all the graphs that compare two teams, the colors would be way easier to follow if they reflected the team colors. Seeing [a team I associate with blue] displayed in blue and [a team I associate with green] displayed in orange was a memory test on basically every page.

  • Good news: with our teams we only have 12 colors. (Maaaaybe 14, if our second travel team gets rolling again, but I don't know what colors they'll use)

  • Bad news: if the background stays white, the team colors for white & yellow seem gratuitously hard, since they might need shadows or something to make them legible).

  • Good news: black or gray background might be fine, as in my screencap.
    team-color-fragment

You don't have to use the colors here, but they are conveniently in the json for each game, at the lines like
"ScoreBoard.PreparedTeam(GreenTeam).Color(scoreboard_bg)" : "#4dff29"
if your engine lets you "just" switch the background to black (or #24292E which was the bgcolor in the screenshot from slack) would it make using our lighter team colors as defined in the file less cascade-prone? Might have to special-case travelteam.gray to something else, but maybe the others would work?

Describe alternatives you've considered
Being smarter? Suffering with the color-confusion? learning python well enough to fix it myself?

Additional context
as dhmay wrote in slack:
For colors: could work fine for all our teams' colors, but I'd worry that it wouldn't work for everyone (Team Midnight!). Easiest would probably be to expose a background color option on the commandline

probably related to any fix for
#24

@erevrav erevrav added the enhancement New feature or request label Dec 21, 2022
@dhmay
Copy link
Owner

dhmay commented Dec 21, 2022

Implemented, mostly. I'm not yet supporting different background colors, so Team White will be out of luck.

If I fail to find the team colors in the JSON file, I default to blue and orange.

@dhmay dhmay closed this as completed Dec 21, 2022
@erevrav erevrav added the fixed Fix has been confirmed (usually by issue opener) label Dec 23, 2022
@erevrav
Copy link
Collaborator Author

erevrav commented Dec 23, 2022

yaaaaaay, mah brain thanks you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request fixed Fix has been confirmed (usually by issue opener)
Projects
None yet
Development

No branches or pull requests

2 participants