Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

loader when search is pressed #420

Merged
merged 3 commits into from
May 13, 2019
Merged

loader when search is pressed #420

merged 3 commits into from
May 13, 2019

Conversation

Carol217
Copy link
Collaborator

No description provided.

@Carol217
loading bar
b5c55e1 
search takes a bit slow, so this'll at least let the user know that things are working
@Carol217
Merge branch 'master' into unify_search
66aeeb1
@Carol217 Carol217 mentioned this pull request May 13, 2019
Closed
ryaanahmed
ryaanahmed approved these changes May 13, 2019
View reviewed changes
Copy link
Member

@ryaanahmed ryaanahmed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great! Check out my changes when you have a chance -- I moved the CSS into styles.css (we shouldn't inline css on the page unless for a very good reason) -- and I jquery-fied the functions that show the loader for ease of readability.

@ryaanahmed ryaanahmed merged commit 3855444 into master May 13, 2019
@ryaanahmed ryaanahmed deleted the unify_search branch May 13, 2019 21:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ryaanahmed ryaanahmed ryaanahmed approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Carol217 @ryaanahmed