Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add version to define-obsolete-function-alias invocation #16

Merged
merged 2 commits into from Apr 14, 2022

Conversation

kekeimiku
Copy link
Contributor

@yashi
Copy link

yashi commented Feb 19, 2021

It looks good but "1.0" is not true. Here are the dates they were obsoleted.

diff --git a/benchmark-init-modes.el b/benchmark-init-modes.el
index 1a5f8c5..eb87e10 100644
--- a/benchmark-init-modes.el
+++ b/benchmark-init-modes.el
@@ -209,7 +209,7 @@
 ;; Obsolete functions
 
 (define-obsolete-function-alias 'benchmark-init/show-durations
-  'benchmark-init/show-durations-tabulated)
+  'benchmark-init/show-durations-tabulated "2014-04-05")
 
 (provide 'benchmark-init-modes)
 ;;; benchmark-init-modes.el ends here
diff --git a/benchmark-init.el b/benchmark-init.el
index 90a69df..4a6aca1 100644
--- a/benchmark-init.el
+++ b/benchmark-init.el
@@ -189,7 +189,7 @@ Slots:
 ;; Obsolete functions
 
 (define-obsolete-function-alias 'benchmark-init/install
-  'benchmark-init/activate)
+  'benchmark-init/activate "2014-03-17")
 
 (provide 'benchmark-init)
 ;;; benchmark-init.el ends here

@kekeimiku
Copy link
Contributor Author

It looks good but "1.0" is not true. Here are the dates they were obsoleted.

diff --git a/benchmark-init-modes.el b/benchmark-init-modes.el
index 1a5f8c5..eb87e10 100644
--- a/benchmark-init-modes.el
+++ b/benchmark-init-modes.el
@@ -209,7 +209,7 @@
 ;; Obsolete functions
 
 (define-obsolete-function-alias 'benchmark-init/show-durations
-  'benchmark-init/show-durations-tabulated)
+  'benchmark-init/show-durations-tabulated "2014-04-05")
 
 (provide 'benchmark-init-modes)
 ;;; benchmark-init-modes.el ends here
diff --git a/benchmark-init.el b/benchmark-init.el
index 90a69df..4a6aca1 100644
--- a/benchmark-init.el
+++ b/benchmark-init.el
@@ -189,7 +189,7 @@ Slots:
 ;; Obsolete functions
 
 (define-obsolete-function-alias 'benchmark-init/install
-  'benchmark-init/activate)
+  'benchmark-init/activate "2014-03-17")
 
 (provide 'benchmark-init)
 ;;; benchmark-init.el ends here

Thank you for the correction.

@kaushalmodi
Copy link

@dholm A gentle nudge to merge this PR please.

@manuel-uberti
Copy link

manuel-uberti commented Jul 30, 2021

@dholm kindly asking what @kaushalmodi asked. :)

@weidtn
Copy link

weidtn commented Jan 4, 2022

@purcell maybe you can merge this?

@purcell
Copy link
Contributor

purcell commented Jan 5, 2022

I don't have commit rights, sorry. But fwiw, this is an uncontroversial and safe change from my perspective.

@wbolster
Copy link

wbolster commented Apr 6, 2022

@dholm is there any way others can help to click the merge button? 🙃 (you click it, or invite contributors to this repo, etc.)

@aladine
Copy link

aladine commented Apr 14, 2022

I drop him an email at dholmster@gmail.com. Hopefully, he will go online, merge this pull request and save the world.

@dholm dholm merged commit 4cf59f6 into dholm:master Apr 14, 2022
@dholm
Copy link
Owner

dholm commented Apr 14, 2022

Thank you very much for the contribution. Sorry for not reacting sooner.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

9 participants