added dsf support, reusing the existing ID3 parser

[ilkomiliev]

please note that this is my very first golang work, so any feedback is appreciated. Still have no clue how to prepare tests, but already questions about this:

1. are you including the necessary music files also in the repo (in case of dsf the files could be huge - the one I've tested with is 300 mb).

2. copyrights: I think some dsd files are provided for test purposes on the web, but haven't check.

[dhowden]

Hey, thanks for the contribution!

I'll try to have a look at the code in the next few days.

To answer your questions: The tag data is in the first few KB of the file, so you shouldn't need to include much for a full test. I don't have any DSF files myself, so if you could post a source of test files here that would be great.

[jooola]

@ilkomiliev If you have a sample file, you can add some testing.

Just check how the tag_test.go file works.

I couldn't find any DSF file, that's weird. So you could create on using the testdata/with_tags/sample.flac file.

[dhowden]

Hey!

Just had a quick look through and made a few comments.

I also looked at the spec and see that the ID3 tags are supposed to be at the end of the DSF files - so I now see your issue with adding some testdata! Don't worry about adding a file, just attach a few test URLs in the comments here so we can try a few and see the code in action.

Thanks again!

[ilkomiliev]

should be ok now. Following site provides a lot of DSF files:
2L
I've tested:
this one

[jooola]

I tried to create a file that we could keep in the repo:
sample.zip

Could you please try it ?

[ilkomiliev]

I tried to create a file that we could keep in the repo:
sample.zip

Could you please try it ?

Metadata Format: ID3v2.3
File Type: DSF
Title: Test Title
Album: Test Album
Artist: Test Artist
Composer: Test Composer
Genre: Jazz
Year: 2000
Track: 3 of 0
Disc: 2 of 0
Picture:
Lyrics:

"TYER": "2000"
"TALB": "Test Album"
"TPE1": "Test Artist"
"TPE2": "Test AlbumArtist"
"TPOS": "2"
"TRCK": "3"
"COMM": &tag.Comm{Language:"eng", Description:"", Text:"Test Comment\x00"}
"TCOM": "Test Composer"
"TCON": "Jazz"
"TIT2": "Test Title"

let me check then how to integrate it into the test suite and I'll update the PR with the tests

[ilkomiliev]

ok, now looks ok - I have to edit the dsf file to add the ttl tracks. Now the test is passing. Please review it again, thanks.

[ilkomiliev]

Hi,

can this be merged or something is still missing?

[dhowden]

Hi there! Apologies, I've been preoccupied with other stuff. As I don't have any DSF files myself - so I could quickly check the implementation - I will just have to read the spec instead (and hence I've been putting it off somewhat!).

If anyone else has DSF files that they can run though that would be great, otherwise I hope to look at this at the weekend.

[jooola]

@ilkomiliev Did you just give up ? Sad...

[ilkomiliev]

no, I've messed up the branches somehow, trying to clean up :-(
let me check again

[ilkomiliev]

ok, back again - good that github is so sophisticated!

[dhowden]

Sorry, I went silent on this.

Not sure what the motivation is behind the compilation scripts and ignore file.

In general I think that the best way to handle things like that is to make official releases, so I won't merge them in.

If you can remove those two new files, I will merge the rest of the PR now.

[dhowden]

Please remove this file.

[ilkomiliev]

sorry for that - it seems I mess it totally, I hope I've fixed everything now. Quite late already here - if something goes wrong again, I'll check it tomorrow.