Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Get picture from OGG file #64

Closed
deluan opened this issue Apr 9, 2020 · 5 comments · Fixed by #69
Closed

Get picture from OGG file #64

deluan opened this issue Apr 9, 2020 · 5 comments · Fixed by #69

Comments

@deluan
Copy link

deluan commented Apr 9, 2020

It seems that the library is not able to get embedded pictures from OGG files. Ex from the attached file:

$ tag 01.ogg
Metadata Format: VORBIS
File Type: OGG
 Title: Over
 Album: Mer de noms
 Artist: Maynard James Keenan (lead vocals)
 Composer: Maynard James Keenan
 Genre: Alternative Rock
 Year: 0
 Track: 12 of 12
 Disc: 1 of 1
 Picture: <nil>
 Lyrics:

01.ogg.zip

Is it a bug? If not, do you have plans to support this?
@wader wader mentioned this issue Apr 10, 2020
Merged
@dhowden dhowden mentioned this issue Apr 10, 2020
Merged
@deluan
Copy link
Author

deluan commented Apr 11, 2020

Unfortunately PR #66 didn't fix this... :(

@wader
Copy link
Contributor

wader commented Apr 11, 2020

Hi, #66 is unrelated, but #65 should fix this

deluan added a commit to navidrome/navidrome that referenced this issue Apr 12, 2020
@deluan
Update dhowden/tag library, to fix extracting images from Ogg files
c4eab5d 
see dhowden/tag#64
@deluan
Copy link
Author

deluan commented Apr 12, 2020

Thanks very much folks, working perfectly!

@wader
Copy link
Contributor

wader commented Apr 16, 2020

Close?

@deluan
Copy link
Author

deluan commented Apr 24, 2020

Hey folks, unfortunately I found another ogg file with comment picture that is not working with tag's latest version:

02.ogg.zip

wader added a commit to wader/tag that referenced this issue Apr 26, 2020
@wader
Add Ogg Opus metadata support
d072771 
Refactor into a ogg demuxer that returns slice of packets
and then look for first vorbis comment or opus tags packet.

Fixes dhowden#64
@wader wader mentioned this issue Apr 26, 2020
Merged
dhowden pushed a commit that referenced this issue May 30, 2022
@wader
Add Ogg Opus metadata support (#69)
77907a3 
Refactor into a ogg demuxer that returns slice of packets
and then look for first vorbis comment or opus tags packet.

Fixes #64
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add Ogg Opus metadata support wader/tag
2 participants
@wader @deluan