Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

change in ad parsing #1535

Merged
merged 5 commits into from Aug 12, 2019
Merged

change in ad parsing #1535

merged 5 commits into from Aug 12, 2019

Conversation

cqx931
Copy link
Collaborator

@cqx931 cqx931 commented Aug 6, 2019

A few tweaks in ad parsing trying to fix many failing cases in ad collection.
Changes:

  • Ad parsing in bootstrapPhase2() instead of bootstrapPhase1(), because many doms may still not loaded in bootstrapPhase1
  • No children checking for HTML and BODY tags, as we don't want to scan the whole webpage for advertisements
  • Remove duplicate ad check in domFilterer.commit()

@cqx931 cqx931 merged commit 8e374ae into dhowe:master Aug 12, 2019
@cqx931 cqx931 mentioned this pull request Sep 19, 2019
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant