Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Opera setting: allow access to search page results #1537

Closed
cqx931 opened this issue Aug 6, 2019 · 5 comments
Closed

Opera setting: allow access to search page results #1537

cqx931 opened this issue Aug 6, 2019 · 5 comments

Comments

@cqx931
Copy link
Collaborator

cqx931 commented Aug 6, 2019

The default for this setting is false. We need to turn this setting on in order to hide and parse text ads from search engines.
image

@cqx931
Copy link
Collaborator Author

cqx931 commented Aug 6, 2019

It doesn't seem like a feature that we could influence, same for uBlock origin.
https://www.reddit.com/r/uBlockOrigin/comments/a147uc/psa_if_youre_using_opera_and_wondering_why_the/

@krystian3w
Copy link

krystian3w commented Aug 7, 2019

IMO: Only possible add instructions on Opera Store in description and maybe hardcode in addon on about page (if anybody read this tab)?


uBlockOrigin/uBlock-issues#319

@cqx931
Copy link
Collaborator Author

cqx931 commented Aug 12, 2019

I agree with what @krystian3w suggests and on top of that, one more thing we might add is to add a menu notification if a user is on opera and the current page is a search result page. However, there is no existing API to know whether the user has turned on this setting or not, but we should be able to know this with some workarounds...

@dhowe
Copy link
Owner

dhowe commented Aug 13, 2019

Two options, both assuming that we can determine if we are on Opera AND that setting is enabled...

  1. If we are on Opera AND that setting is enabled AND the current page is a search page, then show a notification (via our notification mechanism)

  2. If we are on Opera AND that setting is enabled, show a warning on the install screen only

@cqx931
Copy link
Collaborator Author

cqx931 commented Dec 4, 2019

Please check: #1590

I did the workaround by checking the pageStore and see if adnauseam has any pageStore record at all for search engine pages, if not, a notification will show up in the menu.

image

Once the setting is changed, the page needs to be refreshed first to get rid of the notification.

I also added a new FAQ entry here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants