Impossible to delete rule from 'my rules' tab ?

[dhowe]

• to recreate: add a rule, e.g. "* doubleclick.net * strictBlock",
• save
• commit
• close prefs
• re-open
• attempt to delete rule

[cqx931]

seems to me that the the storage and rules are correctly removed in the background but something weird is going on with the code-mirror interface itself.

[dhowe]

this seems to be part of a larger problem with code-mirror in 'my rules'
is code-mirror used elsewhere? we need to check the functioning (and css styling) of all code-mirror instances

see also #1793

[mneunomne]

Yes there are some other issues when you trying to change a rule from block to strictBlock for instance, as described here:

My rules editor -> my rules editor seems to have some problem with strictBlock, after saving and commiting a line with strictBlock the line cant not be change to block allow or noop (when click save, the action changes to undefine and highlighted in codeMirror)...

#1738 (comment)

I'm not sure the issue is with codemirror, I will try to do some test to at least find out where exactly is the problem coming from.

[cqx931]

The issue lies in setCell(), which seems to work for adding but not for removing. When removeFromRuleParts() is called, newBitmap should be 0 but now it remains 4 thus, can't be removed.

Fixing attempt: b56ed5f

[mneunomne]

@cqx931 Nice, It seems like it is working as expected now. Have also tested changing from strictBlock to block which was also causing a bug for example, and it is working.