Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AdNauseam 3.21.4 shows welcome switch page on ever launch of Firefox #2536

Open
3 tasks done
apoapostolov opened this issue May 26, 2024 · 10 comments
Open
3 tasks done
Assignees

Comments

@apoapostolov
Copy link

I tried to reproduce the issue when...

  • AdNauseam is the only extension
  • AdNauseam uses default lists and settings
  • Using a new, unmodified browser profile

Description

Since update to the latest version, every time I restart the browser, AdNauseam shows the webcome screen with the three major switches turned off and I have to turn them each time for the extension to work.

URL(s) where the issue occurs.

No response

Screenshot(s)

No response

Steps to Reproduce

No response

Configuration

Windows, Firefox 128a1

@mneunomne mneunomne self-assigned this Jun 4, 2024
@mneunomne
Copy link
Collaborator

Sounds like a corrupted data file in the firefox profile. @apoapostolov could you please test it on a fresh firefox profile?

@jas01
Copy link

jas01 commented Jun 4, 2024

I got the same issue.
I try installing AdNauseam on the same computer after a mv .mozilla .mozilla_orig and it's work, no bug after the installation, and restart, no need to reconfigure.
But because I'm not the only one, I guessing the probability that two persons got the exact same corruption are not big
Beside AdNauseam I've also got : uBlock Origin, Privacy Badger, Tridactyl and Dark Reader.

I don't have any warning when I'm starting firefox, so I don't even know how to check if my profile are corrupted.

@dhowe
Copy link
Owner

dhowe commented Jun 5, 2024

@jas01 best thing would be to create a fresh firefox profile and test if the problem persists...

@jas01
Copy link

jas01 commented Jun 10, 2024

@jas01 best thing would be to create a fresh firefox profile and test if the problem persists...

Yes I did, I what I mean when I say I launch mv .mozilla .mozilla.orig and yes the problem disappear. But my point is I don't have any warning about corrupt profile.

@teejo75
Copy link

teejo75 commented Jul 22, 2024

I'm also having this issue, although i don't get the welcome, I have to manually enable the three switches before ad nauseum works again. This is with FF 128.

I can confirm that a new FF profile seems to fix this issue.

@dhowe
Copy link
Owner

dhowe commented Jul 25, 2024

If anyone has thoughts on how to detect corrupt profiles (or in what way they are corrupt), would be great to hear

@mneunomne
Copy link
Collaborator

It can either be a problem with the profile itself, or something wrong with the data storage of adnauseam itself.

Maybe someone who is experiencing the issue can help?

If go to the console of adnauseam on firefox:

about:debugging#/runtime/this-firefox -> adnauseam -> inspect

perhaps you can paste this code and see if all the storage currently exists, and if all the keys are there:

browser.storage.local.get(null).then(items => {
  const allKeys = Object.keys(items);
  console.log(allKeys); // Logs all keys
});

where a correct output would be something like this:

0: "admap"
1: "allowedRequestCount"
2: "assetCacheRegistry"
3: "assetSourceRegistry"
4: "availableFilterLists"
5: "blockedRequestCount"
6: "blockingMalware"
7: "cache/adnauseam-filters"
8: "cache/assets.json"
9: "cache/compiled/adnauseam-filters"
10: "cache/compiled/easylist"
11: "cache/compiled/easyprivacy"
12: "cache/compiled/eff-dnt-whitelist"
13: "cache/compiled/ublock-badware"
14: "cache/compiled/ublock-filters"
15: "cache/compiled/ublock-privacy"
16: "cache/compiled/ublock-quick-fixes"
17: "cache/compiled/ublock-unbreak"
18: "cache/compiled/urlhaus-1"
19: "cache/compiled/user-filters"
20: "cache/easylist"
21: "cache/easyprivacy"
22: "cache/eff-dnt-whitelist"
23: "cache/public_suffix_list.dat"
24: "cache/selfie/public_suffix_list.dat"
25: "cache/selfie/redirectEngine/resources"
26: "cache/selfie/staticExtFilteringEngine"
27: "cache/selfie/staticMain"
28: "cache/selfie/staticNetFilteringEngine"
29: "cache/ublock-badlists"
30: "cache/ublock-badware"
31: "cache/ublock-filters"
32: "cache/ublock-privacy"
33: "cache/ublock-quick-fixes"
34: "cache/ublock-unbreak"
35: "cache/urlhaus-1"
36: "cachedManagedStorage"
37: "clickingAds"
38: "compiledMagic"
39: "disableClickingForDNT"
40: "disableHidingForDNT"
41: "dntDomains"
42: "eventLogging"
43: "firstInstall"
44: "hiddenSettings"
45: "hidingAds"
46: "hostnameSwitchesString"
47: "importedLists"
48: "localStorage"
49: "netStrictBlockList"
50: "netWhitelist"
51: "requestStats"
52: "selectedFilterLists"
53: "selfieMagic"
54: "user-filters"
55: "version"
56: "versionUpdateTime"
length: 57
<prototype>: Array []

@teejo75
Copy link

teejo75 commented Jul 27, 2024

This is the object from my broken adnauseum profile:

[
  "admap",
  "allowedRequestCount",
  "assetCacheRegistry",
  "assetSourceRegistry",
  "availableFilterLists",
  "blockedRequestCount",
  "blockingMalware",
  "cache/adguard-cookies",
  "cache/adguard-generic",
  "cache/adguard-mobile-app-banners",
  "cache/adguard-other-annoyances",
  "cache/adguard-popup-overlays",
  "cache/adguard-social",
  "cache/adguard-spyware",
  "cache/adguard-widgets",
  "cache/adnauseam-filters",
  "cache/compiled/adguard-cookies",
  "cache/compiled/adguard-generic",
  "cache/compiled/adguard-mobile-app-banners",
  "cache/compiled/adguard-other-annoyances",
  "cache/compiled/adguard-popup-overlays",
  "cache/compiled/adguard-social",
  "cache/compiled/adguard-spyware",
  "cache/compiled/adguard-widgets",
  "cache/compiled/adnauseam-filters",
  "cache/compiled/easylist",
  "cache/compiled/easylist-annoyances",
  "cache/compiled/easylist-newsletters",
  "cache/compiled/easylist-notifications",
  "cache/compiled/easyprivacy",
  "cache/compiled/fanboy-cookiemonster",
  "cache/compiled/fanboy-social",
  "cache/compiled/fanboy-thirdparty_social",
  "cache/compiled/plowe-0",
  "cache/compiled/ublock-annoyances",
  "cache/compiled/ublock-badware",
  "cache/compiled/ublock-cookies-adguard",
  "cache/compiled/ublock-cookies-easylist",
  "cache/compiled/ublock-filters",
  "cache/compiled/ublock-privacy",
  "cache/compiled/ublock-quick-fixes",
  "cache/compiled/ublock-unbreak",
  "cache/compiled/urlhaus-1",
  "cache/compiled/user-filters",
  "cache/easylist",
  "cache/easylist-annoyances",
  "cache/easylist-newsletters",
  "cache/easylist-notifications",
  "cache/easyprivacy",
  "cache/fanboy-cookiemonster",
  "cache/fanboy-social",
  "cache/fanboy-thirdparty_social",
  "cache/plowe-0",
  "cache/public_suffix_list.dat",
  "cache/selfie/public_suffix_list.dat",
  "cache/selfie/redirectEngine/resources",
  "cache/ublock-annoyances",
  "cache/ublock-badlists",
  "cache/ublock-badware",
  "cache/ublock-cookies-adguard",
  "cache/ublock-cookies-easylist",
  "cache/ublock-filters",
  "cache/ublock-privacy",
  "cache/ublock-quick-fixes",
  "cache/ublock-unbreak",
  "cache/urlhaus-1",
  "cachedManagedStorage",
  "clickingAds",
  "cloudStorageEnabled",
  "compiledMagic",
  "dntDomains",
  "dynamicFilteringString",
  "externalLists",
  "firstInstall",
  "hiddenSettings",
  "hidingAds",
  "hostnameSwitchesString",
  "importedLists",
  "lastBackupFile",
  "lastBackupTime",
  "lastRestoreFile",
  "lastRestoreTime",
  "localStorage",
  "netStrictBlockList",
  "netWhitelist",
  "popupPanelSections",
  "requestStats",
  "selectedFilterLists",
  "selfieMagic",
  "urlFilteringString",
  "user-filters",
  "version",
  "versionUpdateTime"
]

And this is the object from my working profile. I'm not using exactly the same filter lists in the new one, but my personal rules etc are the same.

[
  "admap",
  "assetCacheRegistry",
  "assetSourceRegistry",
  "availableFilterLists",
  "blockingMalware",
  "cache/adguard-cookies",
  "cache/adguard-generic",
  "cache/adguard-mobile-app-banners",
  "cache/adguard-other-annoyances",
  "cache/adguard-popup-overlays",
  "cache/adguard-spyware",
  "cache/adguard-spyware-url",
  "cache/adguard-widgets",
  "cache/adnauseam-filters",
  "cache/assets.json",
  "cache/block-lan",
  "cache/compiled/adguard-cookies",
  "cache/compiled/adguard-generic",
  "cache/compiled/adguard-mobile-app-banners",
  "cache/compiled/adguard-other-annoyances",
  "cache/compiled/adguard-popup-overlays",
  "cache/compiled/adguard-spyware",
  "cache/compiled/adguard-spyware-url",
  "cache/compiled/adguard-widgets",
  "cache/compiled/adnauseam-filters",
  "cache/compiled/block-lan",
  "cache/compiled/curben-phishing",
  "cache/compiled/easylist",
  "cache/compiled/easylist-annoyances",
  "cache/compiled/easylist-chat",
  "cache/compiled/easylist-newsletters",
  "cache/compiled/easylist-notifications",
  "cache/compiled/easyprivacy",
  "cache/compiled/eff-dnt-whitelist",
  "cache/compiled/fanboy-cookiemonster",
  "cache/compiled/plowe-0",
  "cache/compiled/ublock-annoyances",
  "cache/compiled/ublock-badware",
  "cache/compiled/ublock-cookies-adguard",
  "cache/compiled/ublock-cookies-easylist",
  "cache/compiled/ublock-filters",
  "cache/compiled/ublock-privacy",
  "cache/compiled/ublock-quick-fixes",
  "cache/compiled/ublock-unbreak",
  "cache/compiled/urlhaus-1",
  "cache/compiled/user-filters",
  "cache/curben-phishing",
  "cache/easylist",
  "cache/easylist-annoyances",
  "cache/easylist-chat",
  "cache/easylist-newsletters",
  "cache/easylist-notifications",
  "cache/easyprivacy",
  "cache/eff-dnt-whitelist",
  "cache/fanboy-cookiemonster",
  "cache/plowe-0",
  "cache/public_suffix_list.dat",
  "cache/selfie/public_suffix_list.dat",
  "cache/selfie/redirectEngine/resources",
  "cache/selfie/staticExtFilteringEngine",
  "cache/selfie/staticMain",
  "cache/selfie/staticNetFilteringEngine",
  "cache/ublock-annoyances",
  "cache/ublock-badlists",
  "cache/ublock-badware",
  "cache/ublock-cookies-adguard",
  "cache/ublock-cookies-easylist",
  "cache/ublock-filters",
  "cache/ublock-privacy",
  "cache/ublock-quick-fixes",
  "cache/ublock-unbreak",
  "cache/urlhaus-1",
  "cachedManagedStorage",
  "clickingAds",
  "compiledMagic",
  "disableClickingForDNT",
  "disableHidingForDNT",
  "dntDomains",
  "firstInstall",
  "hidingAds",
  "importedLists",
  "localStorage",
  "netStrictBlockList",
  "netWhitelist",
  "requestStats",
  "selectedFilterLists",
  "selfieMagic",
  "user-filters",
  "version",
  "versionUpdateTime"
]

There are some differences to the keys, ignoring the cache entries. I'm not sure if this helps at all.

For what it's worth, I didn't have any indication that there was anything wrong with my firefox profile other than requiring to enable the three main adnauseum settings every time I started firefox.

Screenshot:
image

@mneunomne
Copy link
Collaborator

Then it seems that the problem is not with the storage bring broken somehow. Indeed seems to be that the extension can't write/read the data from the firefox profile. Need to try to reproduce this so I can test at least.

@apoapostolov
Copy link
Author

apoapostolov commented Aug 5, 2024

On my side, the code causes error

browser.storage.local.get(null).then(items => {
  const allKeys = Object.keys(items);
  console.log(allKeys); // Logs all keys
});
Promise { <state>: "pending" }
​
<state>: "rejected"
​
<reason>: Error: An unexpected error occurred
​​
columnNumber: 1
​​
fileName: "undefined"
​​
lineNumber: 0
​​
message: "An unexpected error occurred"
​​
stack: ""
​​
<prototype>: Error.prototype { stack: "", … }
​​​
constructor: function Error()
​​​
message: ""
​​​
name: "Error"
​​​
stack: ""
​​​
toString: function toString()
​​​
<get stack()>: function stack()
​​​
<set stack()>: function stack()
​​​
<prototype>: Object { … }
​
<prototype>: Promise.prototype { … }
​​
catch: function catch()
​​
constructor: function Promise()
​​
finally: function finally()
​​
then: function then()
​​
Symbol(Symbol.toStringTag): "Promise"
​​
<prototype>: Object { … }

Is there a way to fully reset the extension?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants