Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inline pos is incorrect when the vbd and vbn of a word are the same #182

Open
KarlieZhao opened this issue Jun 13, 2022 · 0 comments
Open
Assignees

Comments

@KarlieZhao
Copy link
Collaborator

RiTa.analyze()

let feats = RiTa.analyze("They will be remade into something else.");
expect(feats.pos).eq("prp md vb vbn in nn rb .");
// actual: "prp md vb vbd in nn rb ."

feats = RiTa.analyze("She has become a companion to a foreigner.");
expect(feats.pos).eq("prp vbz vbn dt jj to dt nn .");
// actual: "prp vbz vb dt jj to dt nn .")

RiTa.posInline()

 //'resold': as a vbd
let txt = "She resold her apartment.";
result = RiTa.posInline(txt);
answer = "She/prp resold/vbd her/prp$ apartment/nn .";
eq(result, answer);

 //'resold': as a vbn
txt = "Her apartment was resold.";
result = RiTa.posInline(txt);
answer = "Her/prp$ apartment/nn was/vbd resold/vbn .";
eq(result, answer);

lots of similar cases -- when a word's vbd and vbn are the same, one of the two tests will fail, depending on what the word's first pos tag is in the dictionary. If the first pos is 'vbd', the word will be taken as 'vbd' in both cases.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant