Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix incorrect verb forms in dict #222

Merged
merged 1 commit into from
Jun 13, 2022
Merged

fix incorrect verb forms in dict #222

merged 1 commit into from
Jun 13, 2022

Conversation

KarlieZhao
Copy link
Collaborator

@KarlieZhao KarlieZhao commented Jun 13, 2022

dhowe/rita#177

In dict

  • modified 51 words' incorrect vb/vb* pos & added tests
  • added an entry for "oversell"

In conjugator.js

  • added "resold": "resell" in IRREG_VERBS_LEX, line 430
  • removed “rent” in IRREG_PAST_PART

Found 2 potential problems while trying to make tests past: dhowe/rita#183 and dhowe/rita#182 (for this one, more test cases can be found in tagger-test line 344-403)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants