Improve tools, clean up old data #69
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The most recent kernel, kernel-qemu-4.14.79-stretch, added by commit 36b2f35, is built from the raspberrypi-kernel_1.20181112-1 tag. Update build-kernel-qemu accordingly.
When building on machines with more than 4 cores, the current script would not fully utilize the available resources. Use `nproc` to dynamically figure out the optimal number of build jobs for the current machine.
When building old kernels, the .dtb file will not be generated, resulting in an error when we attempt to copy it. Solve this by only copying the .dtb file if it actually exists.
The configuration is not dynamic, so we can simply store it separately and concatenate it to the configuration file, like we already do with the networking stuff.
CONFIG_CROSS_COMPILE is the only dynamic part of the configuration, so we can move the rest to a separate file. In addition to making the script nicer, this also allows us to store more than one configuration at a time.
Fished out of commit aeb4259. Together, these allow to rebuild kernel-qemu-4.4.34-jessie from the raspberrypi-kernel_1.20161125-1 tag by simply pointing build-kernel-qemu to it.
Just like the unversioned configuration file is used unless a more specific version is requested, and in particular every time the latest kernel is built, it makes sense that the patch would have the same behavior. This avoid the awkward situation where, as it happened when introducing 4.14.79, a new file is introduced despite the previous version of the patch being applicable as-is. Going forward, creating a named patch file will only be necessary when adding support for a new major release of Raspbian.
Since newer kernels work just fine with older images, at least within the same Raspbian release, there is no point in keeping old ones around. Drop all kernels (along with the corresponding patches and configuration files) except for the newest one for each Raspbian release.
|
@andreabolognani : Thanks for the PR. Appreciate your help. 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This series of changes makes it possible to build older kernels using the current script in a simple way, drops all but the most recent kernels since the latter can be used with older images, and performs a few extra smaller cleanups and improvements.