feat: full screen compact view, filtering, markdown rendering #10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Owner
dhth
commented
Jul 21, 2024
•
dhth
commented
- Changes "Compact" list density mode to not be limited to 9 items per page.
- Adds filtering capability to task lists (by manually typing search query)
- Adds a means for quick filtering (via a list)
- Adds markdown rendering via glamour
Closed
dhth
changed the title
Potential follow ups --- - Markdown theme customisation - Fallback rendering - Configurable word wrapping
dhth
commented
Jul 22, 2024
| taskList.FilterInput.SetValue(string(runes[:len(runes)-1])) | ||
| } | ||
|
|
||
| taskList, tlCmd = taskList.Update(tea.KeyMsg{Type: -1, Runes: []int32{47}, Alt: false, Paste: false}) |
There was a problem hiding this comment.
TODO: Filtering this list programmatically by manually updating the list model definitely feels like a hack. Maybe this can be done better.
dhth
changed the title
ccoVeille
reviewed
Jul 23, 2024
| func TestGetContext(t *testing.T) { | ||
| for _, entry := range guideEntries { | ||
| got, err := getContext(entry.summary) | ||
| assert.Nil(t, err) |
There was a problem hiding this comment.
Suggested change
| assert.Nil(t, err) | |
| assert.NotNil(t, err) |
There was a problem hiding this comment.
|
@ccoVeille thanks for the several rounds of reviews :) |
|
You are welcome |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.