Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update libvips to v8.12.2 and enable ImageMagick API bindings #22

Merged
merged 5 commits into from
Apr 10, 2022

Conversation

erichmachado
Copy link
Contributor

This should fix processing Gif images.

Related issue:

libvips/libvips#2574

@erichmachado erichmachado changed the title Update libvips to v8.12.2 Update libvips to v8.12.2 and enable ImageMagick API bindings Apr 8, 2022
@matthewford
Copy link

Within the issue #16 , there is talk about not using the imagemagic bindings and using cgif instead

@erichmachado
Copy link
Contributor Author

Within the issue #16 , there is talk about not using the imagemagic bindings and using cgif instead

Hi @matthewford, thank you for pointing that out.

I saw that issue also, but since apparently there is no cgif package available for the platform versions supported here, one way to support those images without static linking that library is by enabling the Magick API bindings so that Vips is at least able to fallback to it correctly. See this comment.

Since ImageMagick is already provided by Heroku, I imagine that this would be a low-effort solution to support these images in those platform versions. We could then handle migrating to cgif/libspng as a separate effort.

@brandoncc
Copy link
Contributor

This is great @erichmachado, thank you for putting in the work here. I'd really rather use cgif instead of libmagick, since that is what John recommends and it has better performance and output quality. Is there any reason that we would want to support libmagick other than fixing gif saving?

@brandoncc
Copy link
Contributor

I'm going to go ahead and merge this, as I agree with your idea of migrating to cgif/libspng as a separate effort. Thanks again for the work you have done.

@brandoncc brandoncc merged commit 25c582d into dhui5394:master Apr 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants