Extending rss parsing for rough Podcast support #4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for the PR and a really good explanation of the feature, well done :) |
|
Awesome! Thank you, and thanks for the library in the first place again 🙏 it helped out a lot.🙂 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello, thanks for this awesome project! 🙂
I recently used it as a part of grabbing and parsing rss feeds in one of my projects, and while using it I ended up adding some overrides for the parser. Just so I could access specific values for the podcasts ( i.e. where to find their media to play, and their cover art for the episode ( which defaults to the overarching cover art of the podcast if there isn't one ) ).
There might be a more official way to grab the image, but I couldn't figure one out ( not really a python dev, and definitely not very acquainted with xml & parsing ). So, you might want to look this section over
https://github.com/elreydetoda/rss-parser/blob/ccae7b9eb92af958da3d118424025558a90c9272/rss_parser/_parser.py#L18-L26
and it was added because of this section:
https://github.com/elreydetoda/rss-parser/blob/ccae7b9eb92af958da3d118424025558a90c9272/rss_parser/_parser.py#L70-L75
This definitely comprehensive podcast support, but I was just grabbing the small things that I was using so far. Just figured I would toss it your way if you want it. If not, I already have my overrides 🙂