Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pyproject.toml support #25

Merged
merged 3 commits into from May 12, 2022
Merged

pyproject.toml support #25

merged 3 commits into from May 12, 2022

Conversation

woodruffw
Copy link

Teaches bump how to read tool.bump from a project's pyproject.toml.

Needs tests.

Signed-off-by: William Woodruff <william@yossarian.net>
Teaches bump how to read `tool.bump` from a project's `pyproject.toml`.

Signed-off-by: William Woodruff <william@yossarian.net>
Signed-off-by: William Woodruff <william@yossarian.net>
@woodruffw
Copy link
Author

Should be good to go.

Behavior:

  • bump now looks for pyproject.toml in $CWD the same way it does for .bump and setup.cfg
  • If present, settings in pyproject.toml are preferred over other files
  • If a setting is not present, config search falls through to configparser and finally to a controllable default

@@ -3,7 +3,7 @@

setup(
name="bump",
version="1.3.1",
version="1.3.2",
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

But did you do this with bump? 🕵️

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤔 I wonder if the test suite changed that for me? I don't actually remember making that change....

@di di merged commit 6120619 into di:master May 12, 2022
@di
Copy link
Owner

di commented May 12, 2022

Released in https://pypi.org/project/bump/1.3.2/

@di di mentioned this pull request May 12, 2022
@woodruffw woodruffw deleted the ww/toml-support branch May 12, 2022 20:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants