Initial split from sigstore-python
#4
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
di
force-pushed
the
initial-commit
branch
3 times, most recently
from
8067d0c
to
0026d15
Compare
woodruffw
reviewed
Feb 23, 2023
woodruffw
reviewed
Feb 23, 2023
| entrypoint: python | ||
| args: ["-m", "id", "--audience", "throwaway"] | ||
| env: | ||
| - "GOOGLE_SERVICE_ACCOUNT_NAME=sigstore-python-test@projectsigstore.iam.gserviceaccount.com" |
There was a problem hiding this comment.
Maybe a non-issue, but does it make sense to have a different Google service account here?
There was a problem hiding this comment.
Ah, thanks for the reminder, I need to setup these tests to actually run.
woodruffw
reviewed
Feb 23, 2023
woodruffw
reviewed
Feb 23, 2023
| readme = "README.md" | ||
| license = { file = "LICENSE" } | ||
| authors = [ | ||
| { name = "Sigstore Authors", email = "sigstore-dev@googlegroups.com" } |
There was a problem hiding this comment.
Probably needs updating as well.
|
Going to merge this so I can test the GCB integration, will address comments in follow-up PRs. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.