Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Verbose flag #53

Open
wants to merge 9 commits into
base: master
Choose a base branch
from
Open

Verbose flag #53

wants to merge 9 commits into from

Conversation

syxolk
Copy link
Contributor

@syxolk syxolk commented Jan 3, 2018

Fix #50, where all exceptions were collected in the failures dictionary.

Added a new option verbose to Vlad that enables/disables the use of the failures dictionary and _log_debug_failures.

Added new command line option --verbose that enables/disables verbose on all Vlad subclasses that are instantiated. Currently this is not implemented for multiprocessing. Can you help me here?

@syxolk
Copy link
Contributor Author

syxolk commented Jan 3, 2018

Currently this is not implemented for multiprocessing. Can you help me here?

I think, I fixed this. Looks a bit weird, though.

@di
Copy link
Owner

di commented Jan 12, 2018

Thanks @syxolk, sorry I haven't had a chance to review yet. I agree the multiprocessing stuff looks a bit weird but on first glance it seems correct.

@di di mentioned this pull request Mar 1, 2018
@di
Copy link
Owner

di commented Mar 18, 2019

@syxolk Apologies for the delay, are you able to rebase this?

@syxolk
Copy link
Contributor Author

syxolk commented Mar 21, 2019

Yep, will do so tomorrow.

@syxolk
Copy link
Contributor Author

syxolk commented Mar 25, 2019

Rebased branch and reformatted code. My biggest problem was the move of the test files to another location but it should work now again.

@di di mentioned this pull request Mar 26, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants