Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add quiet option to disable console log output from validations #68

Merged
merged 3 commits into from
Nov 12, 2019

Conversation

maleix
Copy link
Contributor

@maleix maleix commented Oct 26, 2019

Fixes #57.

Adding "-q" or "--quiet" to the vladiate execution disables the console log generated by validations.

If used programatically, the feature can be enabled adding disable_console_log=True to the class initialization

The overall result can still be captured by return values.

Copy link
Owner

@di di left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Just a few small changes.

vladiate/main.py Outdated Show resolved Hide resolved
vladiate/vlad.py Outdated Show resolved Hide resolved
README.rst Outdated Show resolved Hide resolved
@maleix
Copy link
Contributor Author

maleix commented Nov 2, 2019

Thanks for the feedback di!
I updated the pull request.

What makes me doubt is how to get the arguments variable from the _vladiate function in main.py.
Making arguments global or passing it as parameter don't seem clean approaches.

@di di merged commit f5d5c26 into di:master Nov 12, 2019
@di
Copy link
Owner

di commented Nov 12, 2019

Thanks! Released in vladiate==0.0.22.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

add a quiet option (-q)
2 participants