Update supported Python versions #92
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Remove Python 3.7 from the test matrix and list of supported versions in `setup.py`, as it reached end of life on 2023-06-27 - Add Python 3.12 to the list of tested / supported versions as the current major version
- Replace usage of `python setup.py test` and the `PyTest` test command with a more direct invocation of `pytest` in `tox.ini` - Replace usage of `pkg_resources.get_distribution` with `importlib.metadata` to get the installed version number for `vladiate`
|
@di does this seem reasonable? I'm sure there's more to be done to modernize the packaging config here, but my main goal was to get tests running for 3.12. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR also makes a few logical changes (mostly regarding test running) in order to get tests to pass under Python 3.12.
setup.py, as it reached end of life on 2023-06-27python setup.py testand thePyTesttest command with a more direct invocation ofpytestintox.inipkg_resources.get_distributionwithimportlib.metadatato get the installed version number forvladiate