Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add scraper for OKEx exchange #35

Merged
merged 1 commit into from
Sep 4, 2018
Merged

Conversation

PumpkingWok
Copy link
Contributor

Description
  • This PR add the scraper for OKEx exchange using websocket.
  • It includes the functions to reconnect to ws and subscribe again to all channels in case of connection error. This happens frequently.
  • There could be a code error into dia/config.go in GetConfig() func, when it istantiates configFileApi, it should forgot .json at the end of string creating, right ? Every exchange scraper catch the error.
  • I used UTC timestamp, it has created during runtime immediately after retrieve the order. I have not used the timestamp into response because it has only the hour, It could be ambiguous. I tested it and the max difference is 2 seconds.
Checklist
  • Changes don't break existing behavior
Affected core subsystem(s)

Scraper Core

Testing

I tested the code in MAC OS environment using go 1.10.3

Refers/Fixes

FIxes: #4

@frranck
Copy link
Contributor

frranck commented Sep 4, 2018

Very good, I will have a look how we can skip this error message for exchanges that don't need an api key.
++

@frranck frranck merged commit 86184c1 into diadata-org:master Sep 4, 2018
@gitcoinbot gitcoinbot mentioned this pull request Sep 4, 2018
codinglittlecat pushed a commit to codinglittlecat/diadata that referenced this pull request Dec 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

OKEx API Scraping
2 participants