fix edge case in graphql's getfeed endpoint.

diadata-org · Sep 12, 2023 · d42ac5f · d42ac5f
1 parent 850b2a9
commit d42ac5f
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 3 deletions.
diff --git a/cmd/http/graphqlServer/go.mod b/cmd/http/graphqlServer/go.mod
@@ -3,7 +3,7 @@ module graphqlServer
 go 1.17
 
 require (
-	github.com/diadata-org/diadata v1.4.338
+	github.com/diadata-org/diadata v1.4.361
 	github.com/graph-gophers/graphql-go v1.1.0
 	github.com/sirupsen/logrus v1.8.1
 )

diff --git a/pkg/graphql/resolver/root.go b/pkg/graphql/resolver/root.go
@@ -559,10 +559,10 @@ func (r *DiaResolver) GetFeed(ctx context.Context, args struct {
 		log.Println("Generating blocks, Total Trades", len(trades))
 		log.Info("generating bins. Total bins: ", len(bins))
 
-		if len(trades) > 0 && len(bins) > 0 {
+		if len(bins) > 0 {
 			// In case the first bin is empty, look for the last trades before @starttime
 			// in order to select the most recent one with sufficient volume.
-			if !utils.IsInBin(trades[0].Time, bins[0]) {
+			if len(trades) == 0 || !utils.IsInBin(trades[0].Time, bins[0]) {
 				previousTrade, err := r.DS.GetTradesByFeedSelection(feedselection, []time.Time{endtime.AddDate(0, 0, -10)}, []time.Time{starttime}, lookbackTradesNumber)
 				if len(previousTrade) == 0 {
 					log.Error("get initial trade: ", err)