close resp body

diadata-org · Sep 4, 2023 · d9f01eb · d9f01eb
1 parent 1fe58ae
commit d9f01eb
Show file tree

Hide file tree

Showing 8 changed files with 46 additions and 14 deletions.
diff --git a/cmd/http/oraclebuilder/utils/podhelper.go b/cmd/http/oraclebuilder/utils/podhelper.go
@@ -245,7 +245,7 @@ func (kh *PodHelper) RestartOracleFeeder(ctx context.Context, feederID string, o
 		//if err != nil {
 		//	return err
 		//}
-		kh.waitPodDeleted(ctx, oracleconfig.Address, func() {
+		deleteerr := kh.waitPodDeleted(ctx, oracleconfig.Address, func() {
 			time.Sleep(1000 * time.Millisecond)
 			err = kh.CreateOracleFeeder(ctx, feederID, oracleconfig.Owner, oracleconfig.Address, oracleconfig.ChainID, strings.Join(oracleconfig.Symbols[:], ","), oracleconfig.FeederSelection, oracleconfig.BlockchainNode, oracleconfig.Frequency, oracleconfig.SleepSeconds, oracleconfig.DeviationPermille, oracleconfig.MandatoryFrequency)
 			if err != nil {
@@ -254,6 +254,9 @@ func (kh *PodHelper) RestartOracleFeeder(ctx context.Context, feederID string, o
 			}
 			log.Infof("Pod %s started\n", feederID)
 		})
+		if deleteerr != nil {
+			log.Infof("Pod %s delete err\n", deleteerr.Error())
+		}
 		log.Infof("Pod %s deleted\n", feederID)
 	}
 

diff --git a/pkg/dia/nft/nftTrade-scrapers/blurV1.go b/pkg/dia/nft/nftTrade-scrapers/blurV1.go
@@ -876,7 +876,12 @@ func (s *BlurV1Scraper) readNFTAttr(ctx context.Context, uri string) (map[string
 		return nil, err
 	}
 
-	defer resp.Body.Close()
+	defer func() {
+		if cerr := resp.Body.Close(); cerr != nil {
+			// Handle the error from closing the response body
+			log.Println("Error closing response body:", cerr)
+		}
+	}()
 
 	if resp.StatusCode < 200 || resp.StatusCode > 299 {
 		return nil, errors.New("unable to read token attributes: " + resp.Status)

diff --git a/pkg/dia/nft/nftTrade-scrapers/looksrare.go b/pkg/dia/nft/nftTrade-scrapers/looksrare.go
@@ -795,8 +795,12 @@ func (s *LooksRareScraper) readNFTAttr(ctx context.Context, uri string) (map[str
 		return nil, err
 	}
 
-	defer resp.Body.Close()
-
+	defer func() {
+		if cerr := resp.Body.Close(); cerr != nil {
+			// Handle the error from closing the response body
+			log.Println("Error closing response body:", cerr)
+		}
+	}()
 	if resp.StatusCode < 200 || resp.StatusCode > 299 {
 		return nil, errors.New("unable to read token attributes: " + resp.Status)
 	}

diff --git a/pkg/dia/nft/nftTrade-scrapers/opensea.go b/pkg/dia/nft/nftTrade-scrapers/opensea.go
@@ -911,8 +911,12 @@ func (s *OpenSeaScraper) readNFTAttr(ctx context.Context, uri string) (map[strin
 		return nil, err
 	}
 
-	defer resp.Body.Close()
-
+	defer func() {
+		if cerr := resp.Body.Close(); cerr != nil {
+			// Handle the error from closing the response body
+			log.Println("Error closing response body:", cerr)
+		}
+	}()
 	if resp.StatusCode < 200 || resp.StatusCode > 299 {
 		return nil, errors.New("unable to read token attributes: " + resp.Status)
 	}

diff --git a/pkg/dia/nft/nftTrade-scrapers/openseaBayc.go b/pkg/dia/nft/nftTrade-scrapers/openseaBayc.go
@@ -871,8 +871,12 @@ func (s *OpenSeaBAYCScraper) readNFTAttr(ctx context.Context, uri string) (map[s
 		return nil, err
 	}
 
-	defer resp.Body.Close()
-
+	defer func() {
+		if cerr := resp.Body.Close(); cerr != nil {
+			// Handle the error from closing the response body
+			log.Println("Error closing response body:", cerr)
+		}
+	}()
 	if resp.StatusCode < 200 || resp.StatusCode > 299 {
 		return nil, errors.New("unable to read token attributes: " + resp.Status)
 	}

diff --git a/pkg/dia/nft/nftTrade-scrapers/openseaSeaport.go b/pkg/dia/nft/nftTrade-scrapers/openseaSeaport.go
@@ -1037,8 +1037,12 @@ func (s *OpenSeaSeaportScraper) readNFTAttr(ctx context.Context, uri string) (ma
 		return nil, err
 	}
 
-	defer resp.Body.Close()
-
+	defer func() {
+		if cerr := resp.Body.Close(); cerr != nil {
+			// Handle the error from closing the response body
+			log.Println("Error closing response body:", cerr)
+		}
+	}()
 	if resp.StatusCode < 200 || resp.StatusCode > 299 {
 		return nil, errors.New("unable to read token attributes: " + resp.Status)
 	}

diff --git a/pkg/dia/nft/nftTrade-scrapers/tofunft.go b/pkg/dia/nft/nftTrade-scrapers/tofunft.go
@@ -782,8 +782,12 @@ func (s *TofuNFTScraper) readNFTAttr(ctx context.Context, uri string) (map[strin
 		return nil, err
 	}
 
-	defer resp.Body.Close()
-
+	defer func() {
+		if cerr := resp.Body.Close(); cerr != nil {
+			// Handle the error from closing the response body
+			log.Println("Error closing response body:", cerr)
+		}
+	}()
 	if resp.StatusCode < 200 || resp.StatusCode > 299 {
 		return nil, errors.New("unable to read token attributes: " + resp.Status)
 	}

diff --git a/pkg/dia/scraper/exchange-scrapers/BitmaxScraper.go b/pkg/dia/scraper/exchange-scrapers/BitmaxScraper.go
@@ -291,8 +291,12 @@ func (s *BitMaxScraper) FetchAvailablePairs() (pairs []dia.ExchangePair, err err
 		log.Error("get symbols: ", err)
 	}
 
-	defer response.Body.Close()
-
+	defer func() {
+		if cerr := response.Body.Close(); cerr != nil {
+			// Handle the error from closing the response body
+			log.Println("Error closing response body:", cerr)
+		}
+	}()
 	body, err := ioutil.ReadAll(response.Body)
 	if err != nil {
 		log.Error("read symbols: ", err)