just some ideas for fixes / conveniences #79
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 17 commits
August 1, 2016 07:51
… configuration file boilerplate around the prefixes
Doing this with a Makefile won't work good, because it won't delete target files ONLY on error, while leaving them alone if they're intermediate.
I keep telling myself I'll go back to python 2 because at least the shoddy syntax doesn't have a lot of retarded boilerplate for encoding/decoding strings. But I just can't give up that unicode support, even if it is (more) shoddy syntax.
Yeah, maybe I should just go back to python 2. Everything's a bytestring, it's all in utf-8, and urllib is eternally stuck in version 2.
"{0}/directory".format(CA)? really?
Just concatenate...
It should be relatively easy to offer the option to execute the commands, instead of begging the user to do it. I for one generate my private keys with the same account that deals with letsencrypt.org, which technically doesn't protect private keys with unix file permissons, but it's convenient at least. It's nicer anyway, to have a standard syntax for lists of commands anyway, instead of just sticking them in the string and trying to figure out which argument {4} corresponds to.
|
I'm trying to get some information from this thread |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
was thinking about using this, but all the manual frittering about with copy and paste was bugging me.
Ideally one would run the command as root, and have it drop permissions before it accesses the network, but the sudo crowd seems to think dropping permissions is eeeevil and it'd be a lot bigger change.
Oh, also -nosudo probably also means -noroot for most people, so I'd have to name it letsencrypt-somethingelse