Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

port to linear #6

Merged
merged 7 commits into from
Oct 10, 2014
Merged

port to linear #6

merged 7 commits into from
Oct 10, 2014

Conversation

jeffreyrosenbluth
Copy link
Member

diagrams-canvas remains specialized to Float, as is the blank-canvas
package. As with rasterific and cairo, see diagrams/diagrams-cairo#54
for a discussion of why float only.

@jeffreyrosenbluth
Copy link
Member Author

Some examples need updating for Direction.
Nothing to do with Linear.

@andygill
Copy link
Contributor

Question: Should blank-canvas use Double everywhere?

@jeffreyrosenbluth
Copy link
Member Author

From the diagrams perspective I don't think it makes a difference using Double or Float.
I'm sure your aware of this:
http://www.haskell.org/haskellwiki/Performance/Floating_point
but it's quite old and I don't know if its relevant anymore

@andygill
Copy link
Contributor

No, I was not. I guessed that most of the advantage of Float went away when we had 64 bit buses, but this says to me we should change to Double, if we do an API bump (which it looks like we've done).

@bergey bergey merged commit 75ecfcc into master Oct 10, 2014
@bergey bergey deleted the linear branch October 29, 2015 14:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants