-
Notifications
You must be signed in to change notification settings - Fork 63
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Now there's only a few conflicts with lens and Prelude. Namely beside, backwards, none, transform, (#) (moved to (##)) and (.>). inside and outside are in Diagrams.BoundingBox but not exported by Prelude.
- Loading branch information
Showing
1 changed file
with
13 additions
and
11 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
da4e3af
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Recent experience with adding
Foldable
andMonoid
to the Prelude have made me wary of convenience re-exports. I think bringing all oflens
into scope will inconvenience many users, and needing an explicit import list forDiagrams
in order to limit thelens
imports is unpleasant. I'd be fine with a new module that re-exports the non-conflicting names fromControl.Lens
. At very least, I've been meaning to document that import line somewhere; thank you for working out what it is.da4e3af
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I see what you mean,
lens
exports a lot but most of the names aren't going to conflict (I made a list http://lpaste.net/124451). Maybe we could prune some more off?I'd you'd still like a separate module I'd prefer to have a
Diagrams
module that only exports functions fromdiagrams
for people that want that. And just have a single prelude that exports almost everything you'd need.I just tried to export both and ghc gave me the list of conflicts :)
da4e3af
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That would also work for me.
I could have been more clear, above. Because
lens
exports so much, I find it's common to overlap with part oflens
I'm not planning to use. It need not be overlap betweenlens
&diagrams
, just overlap betweenlens
and some library or some name I want locally.da4e3af
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe I wasn't clear. I meant most of lens won't conflict with anything (
foldMapByOf
,<<<>=
etc.). I've updated the list with possible conflicts with other libraries (http://lpaste.net/124451), there are others but I think these most of the most used ones. I think I'll exclude these too.I'll still make a
Diagrams
module for just diagrams things.