Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New module enabling nice syntax for constructing and pattern-matching literal points and vectors #1

Merged
merged 3 commits into from
Jul 30, 2012

Conversation

byorgey
Copy link
Member

@byorgey byorgey commented Jul 26, 2012

No description provided.

@mgsloan
Copy link
Member

mgsloan commented Jul 26, 2012

Awesome! I like it! It's impressive how few libraries use (&). fgl, llvm, hmatrix, has, etc. These are all pretty special-purpose, so I think that's fine.

@fryguybob
Copy link
Member

As soon as I saw the patch I wanted to use it :D. It all looks good to me. It seems like it might make the error messages for small point vs vector type mix ups slightly worse, especially if the mistake of expecting (&) to have the same prescience and syntactic support as (,). I think the way through this is to build more compelling high level ways to build paths that do not require talking about specific coordinates as much.

@byorgey
Copy link
Member Author

byorgey commented Jul 30, 2012

Just giving this a bump -- as I explained in a previous email I'd like for the standard workflow to be that one generally doesn't merge one's own pull requests. So if both of you are happy with the current state of these commits, then one of you should merge them. (There's no rush though, just making sure we're on the same page.)

@fryguybob
Copy link
Member

I was going to merge this morning, but I don't have my github password
at work :(. I'll see if I can do it through my ssh key.

Ryan

On Mon, Jul 30, 2012 at 8:42 AM, Brent Yorgey
reply@reply.github.com
wrote:

Just giving this a bump -- as I explained in a previous email I'd like for the standard workflow to be that one generally doesn't merge one's own pull requests. So if both of you are happy with the current state of these commits, then one of you should merge them. (There's no rush though, just making sure we're on the same page.)


Reply to this email directly or view it on GitHub:
#1 (comment)

fryguybob added a commit that referenced this pull request Jul 30, 2012
@fryguybob fryguybob merged commit cc32af7 into diagrams:master Jul 30, 2012
byorgey pushed a commit that referenced this pull request Feb 26, 2024
FSNotify alredy uses WatchModeOS for supported platforms. Current code fails to compile on BSD. This fixes the problem with no ill effects for other platforms.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants