change Codomain of Located to Point (Codomain a) #102
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Switch from
Codomain (Located a) = Located (Codomain a)
to
Codomain (Located a) = Point (Codomain a)
When calling
atParam
on e.g. aLocated (Trail R2)
, I expect to get aP2
, not aLocated R2
(though of course the latter can be converted tothe former).
This also means that instead of requiring constraints of the form
V (Codomain a) ~ V a
we instead have
Codomain a ~ V a
which makes more sense: we can only add a location to
translation-invariant things, and translation-invariant parametric
things are precisely those things whose codomain is a vector space.
@fryguybob , does this make sense to you? I think you're the one who has worked with
Located
the most.