-
Notifications
You must be signed in to change notification settings - Fork 63
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Gradient #136
Gradient #136
Changes from 26 commits
6bb1f53
3be8bdf
7c38e90
ce57c67
5564200
fe1e279
c873735
1f52aac
f546b68
88944c6
933a4dd
977ad18
019990d
f7226b4
685ed07
6317c61
3b4eb9d
8a372a4
047664f
4ab2b26
420399b
57f494d
36935f2
f46b8b0
f1a8217
bb2597c
7261c63
6f236db
2556c12
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -109,7 +109,6 @@ import Data.Semigroup | |
import Data.VectorSpace | ||
|
||
import Data.Colour hiding (atop) | ||
import Diagrams.Attributes | ||
import Diagrams.Core | ||
import Diagrams.Core.Types (QDiaLeaf (..), mkQD') | ||
|
||
|
@@ -119,6 +118,7 @@ import Diagrams.Path | |
import Diagrams.Solve (quadForm) | ||
import Diagrams.Tangent (tangentAtEnd, tangentAtStart) | ||
import Diagrams.Trail | ||
import Diagrams.Attributes | ||
import Diagrams.TwoD.Arrowheads | ||
import Diagrams.TwoD.Attributes | ||
import Diagrams.TwoD.Path (stroke, strokeT) | ||
|
@@ -263,7 +263,7 @@ xWidth p = a + b | |
b = fromMaybe 0 (magnitude <$> traceV origin unit_X p) | ||
|
||
-- | Get the line color from the shaft to use as the fill color for the joint. | ||
colorJoint :: Style v -> Style v | ||
colorJoint :: Style R2 -> Style R2 | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Just curious, why the type change? There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Not important, I'll assume there is some good reason, and I can't imagine wanting to use this with anything other than |
||
colorJoint sStyle = | ||
let c = fmap getLineColor . getAttr $ sStyle in | ||
case c of | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What's the reason for re-exporting this from
Diagrams.TwoD
? I think I intentionally did not re-export it because it is useful only to backend writers, who can importDiagrams.TwoD.Attributes
if they need it; there's no need to export it fromDiagrams.Prelude
.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Your right, I'll take it out