Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Delayed subtrees #137

Merged
merged 9 commits into from Nov 14, 2013
Merged

Delayed subtrees #137

merged 9 commits into from Nov 14, 2013

Commits on Nov 13, 2013

  1. D.TwoD.Arrow: misc cleanup

    Brent Yorgey committed Nov 13, 2013
    Copy the full SHA
    dda7d99 View commit details
    Browse the repository at this point in the history
  2. D.TwoD.Arrow: simplify definition of arrowBetween'

    Brent Yorgey committed Nov 13, 2013
    Copy the full SHA
    fdcdc92 View commit details
    Browse the repository at this point in the history
  3. D.TwoD.Arrow: clarify comments for arrow and arrow'

    Brent Yorgey committed Nov 13, 2013
    2
    Copy the full SHA
    1ba6733 View commit details
    Browse the repository at this point in the history
  4. change arrow' to produce a delayed leaf.

    The idea is that arrow' can now take the *final* transformation into
    account so it can properly decide what to draw.  See #112.
    
    Things seem to be almost working... but it seems we don't quite handle
    frozen transforms properly yet, since things are flipped in the Y-axis.
    Brent Yorgey committed Nov 13, 2013
    Copy the full SHA
    c355559 View commit details
    Browse the repository at this point in the history
  5. Copy the full SHA
    0348a75 View commit details
    Browse the repository at this point in the history
  6. D.TwoD.Arrow: remove debugging output

    Brent Yorgey committed Nov 13, 2013
    Copy the full SHA
    0f58998 View commit details
    Browse the repository at this point in the history
  7. D.TwoD.Arrow: Use existing line color as default for tail, head, and …

    …shaft
    
    This is another cool thing enabled by doing arrows as delayed leaves:
    in addition to knowing the overall transformation in effect when
    drawing an arrow, we know the overall *style*!  So we can grab
    e.g. the line color and use it as a fill color for the arrow head and
    tail.  In particular, this patch sets things up so that line color is
    used by default for the head, tail, and shaft of an arrow.  That is,
    doing (arrow ... # lc blue) will result in a completely blue
    arrow (including head and tail).  This can be overridden by setting
    headStyle, tailStyle, or shaftStyle as usual.
    Brent Yorgey committed Nov 13, 2013
    Copy the full SHA
    26a38f9 View commit details
    Browse the repository at this point in the history

Commits on Nov 14, 2013

  1. D.TwoD.Arrow: remove extraneous word in comment

    Brent Yorgey committed Nov 14, 2013
    Copy the full SHA
    f4ec8d0 View commit details
    Browse the repository at this point in the history
  2. D.TwoD.Arrow: bug fix: actually take unfrozen transform into account!

    Previously, arrow' simply took the tranformation and applied it to the
    points origin and (len,0), and then drew an arrow between the images
    of those points.  However, the transformation might also be doing some
    flipping or shearing which was getting ignored: affine transformations
    are not determined by their action on two points.
    
    This was causing, e.g. shafts to be drawn flipped along the axis of
    the arrow with the SVG backend, since the SVG backend does a `reflectY`
    as the last thing before freezing, but it was getting ignored.
    
    This patch makes `arrow'` properly apply the transformation to the
    shaft trail prior to uniformly scaling and positioning it.
    Brent Yorgey committed Nov 14, 2013
    Copy the full SHA
    8550d63 View commit details
    Browse the repository at this point in the history