Rework of units #169
Merged
Rework of units #169
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fix doc for === and |||
Move FillColor Attributes to subtrees with only Loops
Added bothSize function, lineHead and lineTail
This reverts commit 34b8929. In the end 7.8.1 actually supports this derived instance, without the need for a manual instance due to role restrictions. Conflicts: src/Diagrams/Trail.hs
…ints has no trace It used to simply draw no arrow if either trace returned Nothing. A better default is to simply use the location of the endpoint instead. This way an arrow is *always* drawn. It also allows things like drawing an arrow between a named point (which has no trace) and the boundary of some object.
[ci-skip]
Conflicts: src/Diagrams/Attributes.hs src/Diagrams/TwoD.hs src/Diagrams/TwoD/Arrow.hs src/Diagrams/TwoD/Combinators.hs test/Arrowtest.hs
* move toOutput to generic version in -core * add some Data instances * make lineWidth a "generic" attribute * misc fixes required after merging master
In particular it used 'setAttr' which created a normal Attribute instead of a GTAttribute!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See diagrams/diagrams-core#59 .
Things remaining to do:
GTAttribute(so far I only changed line width)Transformableinstance forMeasure