make headSize and tailSize back into ArrowOpts fields #177
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As attributes, there are situations where it is actually impossible (or at least very difficult) to get things the way you want. E.g. imagine creating a whole bunch of arrows via connectOutside and applyAll, but you want them to have all different head sizes. I am not sure how to accomplish this via attributes at the moment. It is also simply annoying to have some arrow attributes set via ArrowOpts and some as normal attributes. I ran into this when updating the website gallery, it was a confusing error and would have been annoying to fix. In the long term, I would love to have all arrow attributes be normal attributes... but that may have to wait until we have constraint solving and can declare arrows as separate standalone diagrams (to which attributes can be applied). Note this does mean deleting headSizeG, headSizeO, etc. It would be ideal to be able to write e.g. `... & headSizeG .~ 3 & ...` rather than `... & headSize (Global 3) & ...`, however, such a `headSizeG` would not be a valid lens.
|
Yes, having headSize as an attribute and everything else as an ArrowOpt field is terrible. |
jeffreyrosenbluth
added a commit
that referenced
this pull request
Apr 13, 2014
make headSize and tailSize back into ArrowOpts fields
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As attributes, there are situations where it is actually impossible (or
at least very difficult) to get things the way you want. E.g. imagine
creating a whole bunch of arrows via connectOutside and applyAll, but
you want them to have all different head sizes. I am not sure how to
accomplish this via attributes at the moment.
It is also simply annoying to have some arrow attributes set via
ArrowOpts and some as normal attributes. I ran into this when updating
the website gallery, it was a confusing error and would have been
annoying to fix.
In the long term, I would love to have all arrow attributes be normal
attributes... but that may have to wait until we have constraint solving
and can declare arrows as separate standalone diagrams (to which
attributes can be applied).
Note this does mean deleting headSizeG, headSizeO, etc. It would be
ideal to be able to write e.g.
... & headSizeG .~ 3 & ...rather than
... & headSize (Global 3) & ..., however, such aheadSizeGwould not be a valid lens.