Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Texture #181

Merged
merged 10 commits into from May 15, 2014
Merged

Texture #181

merged 10 commits into from May 15, 2014

Conversation

jeffreyrosenbluth
Copy link
Member

Eliminate FillColor and LineColor -- must use gradients

byorgey
byorgey reviewed May 5, 2014
View reviewed changes
src/Diagrams/TwoD/Attributes.hs
getFillColor :: FillColor -> SomeColor
getFillColor (FillColor c) = getLast . getRecommend $ c
--getFillColor :: FillColor -> SomeColor
--getFillColor (FillColor c) = getLast . getRecommend $ c
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's delete this commented-out code

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

will do

@jeffreyrosenbluth
Copy link
Member Author

re headColor, yes i agree, headTexture .~ solid blue is better.
Although I wish I read this before coding up headColor ;-)

@jeffreyrosenbluth
Copy link
Member Author

This branch should be merged before 1.2 is released since with the addition of Gradients, headColor, tailColor, and shaftColor no longer work.

byorgey
byorgey reviewed May 15, 2014
View reviewed changes
src/Diagrams/TwoD/Arrow.hs

-- | A lens for setting or modifying the texture of an arrow
-- head.
-- | A lens for setting or modifying the texture of an arrowhead. For
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe we should mention another example here that uses solid.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, that's a good idea.

byorgey added a commit that referenced this pull request May 15, 2014
@byorgey
Merge pull request #181 from diagrams/texture
5685807 
Texture
@byorgey byorgey merged commit 5685807 into master May 15, 2014
@byorgey byorgey deleted the texture branch May 15, 2014 02:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@jeffreyrosenbluth @byorgey