Add Native images to Diagrams.TwoD.Image #199
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -49,12 +49,14 @@ import Data.Semigroup | |||
|
|
|||
| data Embedded deriving Typeable | |||
| data External deriving Typeable | |||
| data Native (t :: *) deriving Typeable | |||
|
|
|||
| -- | 'ImageData' is either a JuicyPixels @DynamicImage@ tagged as 'Embedded' or | |||
| -- a reference tagged as 'External'. | |||
There was a problem hiding this comment.
This comment should be updated as well.
byorgey
added a commit
that referenced
this pull request
Jun 23, 2014
Add Native images to Diagrams.TwoD.Image
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a type for "Native" images that can be hooked by other packages.
This makes it possible to write libraries like:
https://taruti.github.io/diagrams-cairo-raster/
The issue with using "Embedded" images is that they are typically not in the pixel format that the backend likes. When using images as tiles (the same image is rendered many times) doing a costly conversion step on each "render" is not feasible.
This minimal support for "Native" images makes it possible to write high-performance native backend specific raster image functionality.