New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

updated changes for GHC-7.10 #239

Merged
merged 3 commits into from Mar 10, 2015

Conversation

Projects
None yet
4 participants
@bergey
Member

bergey commented Mar 5, 2015

This supercedes #238

Compared to that PR:

  • it is rebased onto master
  • several commits are squashed to avoid spurious whitespace changes
  • changes from the travis branch are included

I've built it locally with GHC-7.10, but haven't updated the travis
branch since rebasing.

bergey added some commits Feb 27, 2015

update for GHC-7.10, -Wall
- remove tabs
- handle extra imports of Foldable, Traversable, Monoid

By some combination of the import Prelude hack, where effective, CPP,
and -fno-warn.
@bergey

This comment has been minimized.

Show comment
Hide comment
@bergey

bergey Mar 5, 2015

Member

I don't understand why the travis build succeeded. I expected it to fail while installing dependencies, as did the build in #238

Member

bergey commented Mar 5, 2015

I don't understand why the travis build succeeded. I expected it to fail while installing dependencies, as did the build in #238

@byorgey

This comment has been minimized.

Show comment
Hide comment
@byorgey

byorgey Mar 9, 2015

Member

Looks good to me. Is this ready to merge or are we still waiting for something? (Perhaps waiting to see whether <$> gets snuck into the Prelude at the last minute?)

Member

byorgey commented Mar 9, 2015

Looks good to me. Is this ready to merge or are we still waiting for something? (Perhaps waiting to see whether <$> gets snuck into the Prelude at the last minute?)

@bergey

This comment has been minimized.

Show comment
Hide comment
@bergey

bergey Mar 9, 2015

Member

I think we should merge this, and deal with <$> when it happens.

Member

bergey commented Mar 9, 2015

I think we should merge this, and deal with <$> when it happens.

@cchalmers

This comment has been minimized.

Show comment
Hide comment
@cchalmers

cchalmers Mar 9, 2015

Member

Sounds good to me.

Member

cchalmers commented Mar 9, 2015

Sounds good to me.

byorgey added a commit that referenced this pull request Mar 10, 2015

@byorgey byorgey merged commit fdb6e5c into master Mar 10, 2015

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@bergey bergey deleted the ghc-710-v2 branch Mar 10, 2015

@fryguybob

This comment has been minimized.

Show comment
Hide comment
Member

fryguybob commented Mar 12, 2015

@bergey

This comment has been minimized.

Show comment
Hide comment
@bergey

bergey Mar 12, 2015

Member

Yep. I'm looking forward to getting tomorrows RC and making another round of changes.

Member

bergey commented Mar 12, 2015

Yep. I'm looking forward to getting tomorrows RC and making another round of changes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment