Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix capArc for changed dirBetween #310

Merged
merged 1 commit into from
Mar 19, 2018
Merged

fix capArc for changed dirBetween #310

merged 1 commit into from
Mar 19, 2018

Conversation

robx
Copy link
Contributor

@robx robx commented Mar 7, 2018

expandTrail with LineCapRound seems to have been broken in 67901ac. This updates dirBetween use to the new argument order.

(The graphics in the expandTrail' haddocks look fine, but maybe they weren't updated for the release?)

diagrams-lib-1.4.1.2:
wordsearch-example

diagrams-lib-1.4.2:
wordsearch-example

@robx
Copy link
Contributor Author

robx commented Mar 7, 2018

Travis failures seem unrelated to the change.

@robx
Copy link
Contributor Author

robx commented Mar 19, 2018

@byorgey ping

@byorgey
Copy link
Member

byorgey commented Mar 19, 2018

Sorry, I was working on an ICFP submission --- but now the ICFP submission is done and it's spring break so I will get around to this (and a bunch of other diagrams updates & fixes) very soon!

@byorgey
Copy link
Member

byorgey commented Mar 19, 2018

Thanks for the catch. And yes, you're right that the graphics were not updated for the release which is why they didn't break. I have confirmed that we don't use dirBetween anywhere else in the codebase.

@byorgey byorgey merged commit fad4346 into diagrams:master Mar 19, 2018
@robx
Copy link
Contributor Author

robx commented Mar 22, 2018

thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants