Attempt to fix some issues with Bezier intersections. #325
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There are several issues with the code for Bezier Bezier intersections right now. This tries to fix some of them. I haven't been able to test yet due to my ghc/cabal being ... interesting.
|
Do you need help testing it? |
|
I was able to test against the original issue code, now I just need to validate against any tests we have that use intersections. |
A simple test that validates that the parameters returned match the points at those parameters. Not included is any test of false negative intersections (empty list of intersections).
|
This passed the test I wrote. If someone wants to look over that to make sure I haven't done something silly, then this can be merged. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are several issues with the code for Bezier
Bezier intersections right now. This tries to fix
some of them. I haven't been able to test yet due
to my ghc/cabal being ... interesting.
This should fix #323 (I payed attention to the issue text this time :D).