Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Envelope deformation #60

Merged
merged 4 commits into from
Nov 2, 2012
Merged

Envelope deformation #60

merged 4 commits into from
Nov 2, 2012

Conversation

mgsloan
Copy link
Member

@mgsloan mgsloan commented Nov 1, 2012

@byorgey
Copy link
Member

byorgey commented Nov 1, 2012

Cool, I look forward to playing with it soon. So, just to be clear, this one replaces #40, i.e. #40 should be closed now, right? ...oh, hehe, looks like I was writing this comment at exactly the same time that you were closing #40. =)

@mgsloan
Copy link
Member Author

mgsloan commented Nov 1, 2012

Not sure why the first two commits are on there - I think it's due to a rebase. Since they're already in the repo it'll probably merge fine.

@byorgey
Copy link
Member

byorgey commented Nov 2, 2012

Very cool, I finally got everything building to play with the interactive demo. =) Looks good to me! And the old tests from #40 (e.g. the extruded circle that looked like it was being extruded too far, etc.) now seem to work fine.

byorgey added a commit that referenced this pull request Nov 2, 2012
@byorgey byorgey merged commit 1f78e20 into diagrams:master Nov 2, 2012
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants