do scaling on a Path before constructing PathLike in 'rect' (fixes #43) #70
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We used to have rect w h = unitSquare # scaleX w # scaleY h since unitSquare can produce any PathLike. The new code instead uses (unitSquare # scaleX w # scaleY h) to specifically produce a Path, which is then deconstructed and passed into 'pathLike' to create any PathLike. The difference is that while scaling by zero works fine for Path it does not work very well for, say, Diagrams (leading to NaNs or worse). This way, we force the scaling to happen on a Path, where we know it will behave properly, and then use the resulting geometry to construct an arbitrary PathLike.
|
Oh, and this should fix #51 as well. |
fryguybob
added a commit
that referenced
this pull request
Jan 1, 2013
do scaling on a Path before constructing PathLike in 'rect' (fixes #43)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We used to have
since
unitSquarecan produce anyPathLike. The new codeinstead uses
(unitSquare # scaleX w # scaleY h)to specificallyproduce a
Path, which is then deconstructed and passed intopathLiketo create anyPathLike.The difference is that while scaling by zero works fine for
Pathit does not work very well for, say,Diagrams (leading toNaNs or worse). This way, we force the scaling to happen on a
Path, where we know it will behave properly, and then use theresulting geometry to construct an arbitrary
PathLike.