removed default implementation of reverseDomain #97
Conversation
… appropriate classes
| @@ -138,6 +138,8 @@ instance ( Codomain a ~ V a, Fractional (Scalar (V a)), AdditiveGroup (V a) | |||
| splitAtParam (Loc x a) p = (Loc x a1, Loc (x .+^ (a `atParam` p)) a2) | |||
| where (a1,a2) = splitAtParam a p | |||
|
|
|||
| reverseDomain (Loc p a) = Loc p (reverseDomain a) | |||
There was a problem hiding this comment.
Hmm, I don't think this is correct. Reversing a Located thing might result in a thing with a different location. e.g. see the definition of reverseLocLine here: https://github.com/diagrams/diagrams-lib/blob/master/src/Diagrams/Trail.hs#L868 . The idea is that the new location is what used to be the end (so overall the located thing "stays in the same place"). Concretely, the idea would be to compute the offset of the underlying parametric thing (by subtracting atStart from atEnd) and to add that to the point p to obtain the new location. I am not 100% confident all the types will work out, but I think they should. Let me know if you run into trouble.
There was a problem hiding this comment.
Ok, how about the other two?
There was a problem hiding this comment.
Yeah, everything else looks good.
removed default implementation of reverseDomain
Added reverseDomain implementations for:
Sectionable (SegTree v)
Sectionable (Trail' Line v)
Located a