Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

npm audit fix #7

Open
wants to merge 6 commits into
base: develop
Choose a base branch
from
Open

npm audit fix #7

wants to merge 6 commits into from

Conversation

edunston
Copy link

npm audit fix: none breaking changes only

@mrister
Copy link

mrister commented Jun 24, 2018

Based on this discussion, it seems we should not use any package-lock.json files for non apps.
sindresorhus/ama#479
@dial-once/developers please have a reed.

Copy link

@mrister mrister left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remove lockfile

Copy link
Contributor

@jkernech jkernech left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove lock file

@edunston
Copy link
Author

edunston commented Jul 2, 2018

1 low vulnerability remaining, to fix by hand. All test passed, with one warning `/Users/Eric/Documents/Dial-Once 2017/node-logtify-logentries/src/index.js
39:7 warning Unexpected console statement no-console

✖ 1 problem (0 errors, 1 warning)`

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants