-
-
Notifications
You must be signed in to change notification settings - Fork 70
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update gettext code to use two catalogues for language names and UI #328
Conversation
for language names and UI
@mufeedali Hey, merged the new structure on Tested this (installing the flatpak locally) and seems to be working fine, could you test it too? :p |
Discovered something funny. if I run |
Wow, that is interesting... then what would be the correct way to set per-app locale? |
Not sure. The thing is that it only works if I use But in the other hand is pretty strange that it gets the langs names right. |
So changed my system language to Portuguese and the issue happens. |
Tested again using the |
Okay, looks good. Thanks for confirming! |
Other complementary changes:
from gettext import gettext as _
since_()
should be already installed on the global namespace.gettext()
and use it to get lang names and avoid including those strings on the regular UI po file.define
module as a plain dict.BaseProvider.add_lang()
) since theALIASES
list is growing.Depends on dialect-app/po#16.