Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor: foreground and background words #30

Closed
dialex opened this issue Dec 20, 2019 · 0 comments · Fixed by #49
Closed

Refactor: foreground and background words #30

dialex opened this issue Dec 20, 2019 · 0 comments · Fixed by #49
Labels
improvement-refactor
Milestone
v4.*

Comments

@dialex
Copy link
Owner

dialex commented Dec 20, 2019 •
edited
Loading

  • withForeground -> withText
  • withBackground -> withBack

it would make the text shorter and more intuitive... but it would be breaking change (is it worth it?)
doesn't have to be a hard rename, it can be just an alias
@dialex dialex changed the title Refactor: withForeground -> withText, withBackground -> withBack Refactor: foreground and background words Dec 20, 2019
@dialex dialex added this to the v4.* milestone Dec 21, 2019
@dialex dialex mentioned this issue Jun 22, 2020
Closed
@dialex dialex mentioned this issue Jul 5, 2020
Merged
@dialex dialex closed this as completed in #49 Jul 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
improvement-refactor
Projects
None yet
Milestone
v4.*
1 participant
@dialex