Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't link to removed thread library #19

Merged
merged 1 commit into from
Oct 9, 2017

Conversation

jbuck
Copy link
Contributor

@jbuck jbuck commented Jun 29, 2017

Hi there, I've been working on getting this working for a project at work. In kaldi-asr/kaldi@6cc8e3a the kaldi project removed the vendored pthread library to use the STL thread library. This patch removes the now-deleted lib so it can compile with the latest kaldi master branch.

@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed, please reply here (e.g. I signed it!) and we'll verify. Thanks.


  • If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data and verify that your email is set on your git commits.
  • If your company signed a CLA, they designated a Point of Contact who decides which employees are authorized to participate. You may need to contact the Point of Contact for your company and ask to be added to the group of authorized contributors. If you don't know who your Point of Contact is, direct the project maintainer to go/cla#troubleshoot.
  • In order to pass this check, please resolve this problem and have the pull request author add another comment and the bot will run again.

@realill
Copy link
Contributor

realill commented Jul 7, 2017

@jbuck please sign CLA before I can merge this.

@jbuck
Copy link
Contributor Author

jbuck commented Jul 9, 2017

I signed it!

@googlebot
Copy link

CLAs look good, thanks!

@achernetsov
Copy link

Hello, @realill, are you planning to merge this?

@realill realill merged commit b23f779 into dialogflow:master Oct 9, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants